chore: flatten subset
in unique
one level up
#1671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, it's probably good if we simplify the implementation of
CompliantFrame
s by doing these kinds of operations at the Narwhals levelIf we want to encourage people to extend Narwhals, it'll be easier if they just have to worry about
subset: list[str] | None
rather thansubset: str | list[str] | None
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below