Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for nw.Expr|Series.str.contains with literal=True #1670

Merged

Conversation

AlessandroMiola
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

Adds test for nw.Expr.str.contains and nw.Series.str.contains with literal=True.

@AlessandroMiola AlessandroMiola marked this pull request as ready for review December 28, 2024 19:23
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, thanks @AlessandroMiola !

@MarcoGorelli MarcoGorelli merged commit f26b765 into narwhals-dev:main Dec 28, 2024
24 checks passed
@AlessandroMiola AlessandroMiola deleted the test-str-contains-literal branch December 28, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: add test which uses str.contains(..., literal=True)
2 participants