Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ArrowDataFrame.explode #1644

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

feat: ArrowDataFrame.explode #1644

wants to merge 19 commits into from

Conversation

FBruzzesi
Copy link
Member

@FBruzzesi FBruzzesi commented Dec 22, 2024

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

I will leave this as draft until we decide how to move forward.

To summarize the discussion(s) in #1542 :

  • pyarrow native methods ignore nulls and empty list in explode
  • the workaround here is to have a "fast_path" for when nulls or empty lists are not present, and a dedicated path for when they are
  • the issue is that we enter python world to create the index via one .to_pylist() call
  • pandas seems to enter cython anyway to explode a list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant