-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for .shift(n).over('col')
for pandas-like DataFrames
#1627
feat: Add support for .shift(n).over('col')
for pandas-like DataFrames
#1627
Conversation
.shift(n).over('col')
for pandas-like DataFrames
nice, thanks @ClaudioSalvatoreArcidiacono ! I think @FBruzzesi 's work in #1614 might make this easier, perhaps we should wait to get that in, then we can update here? |
Thanks @ClaudioSalvatoreArcidiacono ! I was about to echo what @MarcoGorelli just mentioned! Instead of an ad-hoc change, I think waiting for #1614 would make it easier. Possibly it will be ready by end of today. |
Definetly! Nice PR @FBruzzesi |
that PR's merged, if you fancy updating @ClaudioSalvatoreArcidiacono I think we'd love to get this in! |
Just a headsup that the PR was shipped with a bug, namely it does not track kwargs in expr composition. You would probably want to wait for #1645 which contains a fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty happy with this! I left only a tiny comment before merging!
Accept comment Co-authored-by: Francesco Bruzzesi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton @ClaudioSalvatoreArcidiacono π
What type of PR is this? (check all applicable)
Related issues
nw.col('a').shift(n).over('b')
Β #1609Checklist
If you have comments or can explain your changes, please do so below
See #1609