fix: narwhals_to_native_dtype raise if polars dtype is passed
#1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
commented
Nov 2, 2024
| @@ -76,6 +77,17 @@ def native_to_narwhals_dtype(dtype: Any, dtypes: DTypes) -> DType: | |||
|
|
|||
|
|
|||
| def narwhals_to_native_dtype(dtype: DType | type[DType], dtypes: DTypes) -> Any: | |||
| if (pl := get_polars()) is not None and isinstance( | |||
| dtype, (pl.DataType, pl.DataType.__class__) | |||
There was a problem hiding this comment.
pl.DataType.__class__ is a workaround since pl.DataTypeClass now raises a DeprecationWarning.
I think this is the best way to check for both pl.String() and pl.String: if "polars" in str(type(dtype)) was definitly not enough for both
MarcoGorelli
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.