mypy in pre-commit

narwhals-dev · Feb 23, 2024 · eea8f83 · eea8f83
1 parent b0e0997
commit eea8f83
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 4 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -8,4 +8,9 @@ repos:
       args: [--fix]
     # Run the formatter.
     - id: ruff-format
-
+-   repo: https://github.com/pre-commit/mirrors-mypy
+    rev: 'v1.8.0'
+    hooks:
+    -   id: mypy
+        additional_dependencies: ['polars==0.20.10', 'pytest==8.0.1']
+        exclude: utils
diff --git a/narwhals/spec/__init__.py b/narwhals/spec/__init__.py
@@ -18,6 +18,9 @@ def alias(self, name: str) -> Self:
     def cast(self, dtype: DType) -> Self:
         ...
 
+    def __eq__(self, other: object) -> Expr:  # type: ignore[override]
+        ...
+
     def __and__(self, other: Any) -> Expr:
         ...
 

diff --git a/tpch/q1.py b/tpch/q1.py
@@ -8,7 +8,7 @@
 polars.Config.set_tbl_cols(10)
 
 
-def q1(df_raw: Any) -> None:
+def q1(df_raw: Any) -> Any:
     var_1 = datetime(1998, 9, 2)
     df, pl = to_polars_api(df_raw, version="0.20")
     result = (

diff --git a/tpch/q4.py b/tpch/q4.py
@@ -13,7 +13,7 @@
 def q4(
     lineitem_ds_raw: Any,
     orders_ds_raw: Any,
-):
+) -> Any:
     var_1 = datetime(1993, 7, 1)
     var_2 = datetime(1993, 10, 1)
 

diff --git a/tpch/q5.py b/tpch/q5.py
@@ -15,7 +15,7 @@ def q5(
     lineitem_ds_raw: Any,
     orders_ds_raw: Any,
     supplier_ds_raw: Any,
-):
+) -> Any:
     var_1 = "ASIA"
     var_2 = datetime(1994, 1, 1)
     var_3 = datetime(1995, 1, 1)
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,6 +18,9 @@ def alias(self, name: str) -> Self: @@
         def cast(self, dtype: DType) -> Self:
             ...
+        def __eq__(self, other: object) -> Expr:  # type: ignore[override]
+            ...
         def __and__(self, other: Any) -> Expr:
             ...
@@ Expand Down @@