fix: exclude protocols in api completeness script (#1635)

narwhals-dev · Dec 21, 2024 · 9c69d7d · 9c69d7d
1 parent 7a19378
commit 9c69d7d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/noxfile.py b/noxfile.py
@@ -14,7 +14,7 @@
 
 
 def run_common(session: Session, coverage_threshold: float) -> None:
-    session.install('-e ".[dev]"')
+    session.install("-e .[dev]")
 
     if session.python != "3.8":
         session.install("ibis-framework>=6.0.0", "rich", "packaging", "pyarrow_hotfix")

diff --git a/utils/generate_backend_completeness.py b/utils/generate_backend_completeness.py
@@ -50,8 +50,13 @@ def parse_module(module_name: str, backend: str, nw_class_name: str) -> list[str
         module_ = importlib.import_module(f"narwhals.{backend}.{module_name}")
         class_ = inspect.getmembers(
             module_,
-            predicate=lambda c: inspect.isclass(c) and c.__name__.endswith(nw_class_name),
+            predicate=lambda c: (
+                inspect.isclass(c)
+                and c.__name__.endswith(nw_class_name)
+                and not c.__name__.startswith("Compliant")  # Exclude protocols
+            ),
         )
+
         methods_ = (
             get_class_methods(class_[0][1]) + DIRECTLY_IMPLEMENTED_METHODS
             if class_