chore: flatten subset in unique one level up

narwhals/_arrow/dataframe.py

@@ -641,7 +641,7 @@ def is_unique(self: Self) -> ArrowSeries:
 
     def unique(
         self: Self,
-        subset: str | list[str] | None,
+        subset: list[str] | None,
         *,
         keep: Literal["any", "first", "last", "none"],
         maintain_order: bool,
@@ -653,9 +653,6 @@ def unique(
         import pyarrow.compute as pc
 
         df = self._native_frame
-
-        if isinstance(subset, str):
-            subset = [subset]
         subset = subset or self.columns
 
         if keep in {"any", "first", "last"}:

narwhals/_dask/dataframe.py

@@ -198,14 +198,13 @@ def head(self: Self, n: int) -> Self:
 
     def unique(
         self: Self,
-        subset: str | list[str] | None,
+        subset: list[str] | None,
         *,
         keep: Literal["any", "first", "last", "none"] = "any",
         maintain_order: bool = False,
     ) -> Self:
         # The param `maintain_order` is only here for compatibility with the Polars API
         # and has no effect on the output.
-        subset = flatten(subset) if subset else None
         native_frame = self._native_frame
         if keep == "none":
             subset = subset or self.columns

narwhals/_pandas_like/dataframe.py

@@ -684,15 +684,14 @@ def tail(self, n: int) -> Self:
 
     def unique(
         self: Self,
-        subset: str | list[str] | None,
+        subset: list[str] | None,
         *,
         keep: Literal["any", "first", "last", "none"] = "any",
         maintain_order: bool = False,
     ) -> Self:
         # The param `maintain_order` is only here for compatibility with the Polars API
         # and has no effect on the output.
         mapped_keep = {"none": False, "any": "first"}.get(keep, keep)
-        subset = flatten(subset) if subset else None
         return self._from_native_frame(
             self._native_frame.drop_duplicates(subset=subset, keep=mapped_keep)
         )

narwhals/dataframe.py

@@ -153,6 +153,8 @@ def unique(
         keep: Literal["any", "first", "last", "none"] = "any",
         maintain_order: bool = False,
     ) -> Self:
+        if isinstance(subset, str):
+            subset = [subset]
         return self._from_compliant_dataframe(
             self._compliant_frame.unique(
                 subset=subset, keep=keep, maintain_order=maintain_order