try reenabling nightlies

narwhals-dev · Sep 12, 2024 · 83049d8 · 83049d8
1 parent a3b6a75
commit 83049d8
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 48 deletions.
diff --git a/.github/workflows/extremes.yml b/.github/workflows/extremes.yml
@@ -79,7 +79,7 @@ jobs:
       - name: Run doctests
         run: pytest narwhals --doctest-modules
 
-  pandas-nightly-and-dask:
+  nightlies:
     strategy:
       matrix:
         python-version: ["3.12"]
@@ -97,6 +97,8 @@ jobs:
         run: uv pip install polars --system
       - name: install-reqs
         run: uv pip install --upgrade tox virtualenv setuptools pip -r requirements-dev.txt --system
+      - name: uninstall polars
+        run: uv pip uninstall polars --system
       - name: uninstall pyarrow
         run: uv pip uninstall pyarrow --system
       # - name: install pyarrow nightly
@@ -112,50 +114,19 @@ jobs:
       - name: install dask
         run: |
           python -m pip install git+https://github.com/dask/distributed git+https://github.com/dask/dask git+https://github.com/dask/dask-expr
+      - name: install-kaggle
+        run: python -m pip install kaggle
+      - name: Download Kaggle notebook artifact
+        env:
+          KAGGLE_USERNAME: ${{ secrets.KAGGLE_USERNAME }}
+          KAGGLE_KEY: ${{ secrets.KAGGLE_KEY }}
+        run: kaggle kernels output marcogorelli/polars-nightly
+      - name: install-polars-nightly
+        run: python -m pip install *.whl
       - name: show-deps
         run: uv pip freeze
       - name: Run pytest
         run: pytest tests --cov=narwhals --cov=tests --cov-fail-under=50 --runslow
       - name: Run doctests
         run: pytest narwhals --doctest-modules
 
-  # polars-nightly:
-  #   if: github.ref == 'refs/heads/main'
-  #   strategy:
-  #     matrix:
-  #       python-version: ["3.12"]
-  #       os: [ubuntu-latest]
-
-  #   runs-on: ${{ matrix.os }}
-  #   steps:
-  #     - uses: actions/checkout@v4
-  #     - uses: actions/setup-python@v5
-  #       with:
-  #         python-version: ${{ matrix.python-version }}
-  #     - name: Cache multiple paths
-  #       uses: actions/cache@v4
-  #       with:
-  #         path: |
-  #           ~/.cache/pip
-  #           $RUNNER_TOOL_CACHE/Python/*
-  #           ~\AppData\Local\pip\Cache
-  #         key: ${{ runner.os }}-build-${{ matrix.python-version }}
-  #     - name: install-kaggle
-  #       run: python -m pip install kaggle
-  #     - name: Download Kaggle notebook artifact
-  #       env:
-  #         KAGGLE_USERNAME: ${{ secrets.KAGGLE_USERNAME }}
-  #         KAGGLE_KEY: ${{ secrets.KAGGLE_KEY }}
-  #       run: kaggle kernels output marcogorelli/polars-nightly
-  #     - name: install-reqs
-  #       run: python -m pip install --upgrade tox virtualenv setuptools pip -r requirements-dev.txt
-  #     - name: uninstall polars
-  #       run: python -m pip uninstall polars -y
-  #     - name: install-modin-pandas
-  #       run: pip install modin[dask] pandas
-  #     - name: install-polars-nightly
-  #       run: python -m pip install *.whl
-  #     - name: Run pytest
-  #       run: pytest tests --cov=narwhals --cov=tests --cov-fail-under=50
-  #     - name: Run doctests
-  #       run: pytest narwhals --doctest-modules
diff --git a/tests/expr_and_series/dt/to_string_test.py b/tests/expr_and_series/dt/to_string_test.py
@@ -130,10 +130,8 @@ def test_dt_to_string_iso_local_datetime_series(
 )
 @pytest.mark.skipif(is_windows(), reason="pyarrow breaking on windows")
 def test_dt_to_string_iso_local_datetime_expr(
-    request: Any, constructor: Any, data: datetime, expected: str
+    constructor: Any, data: datetime, expected: str
 ) -> None:
-    if "modin" in str(constructor):
-        request.applymarker(pytest.mark.xfail)
     df = constructor({"a": [data]})
 
     result = nw.from_native(df).with_columns(
@@ -166,11 +164,8 @@ def test_dt_to_string_iso_local_date_series(
 )
 @pytest.mark.skipif(is_windows(), reason="pyarrow breaking on windows")
 def test_dt_to_string_iso_local_date_expr(
-    request: Any, constructor: Any, data: datetime, expected: str
+    constructor: Any, data: datetime, expected: str
 ) -> None:
-    if "modin" in str(constructor):
-        request.applymarker(pytest.mark.xfail)
-
     df = constructor({"a": [data]})
     result = nw.from_native(df).with_columns(
         nw.col("a").dt.to_string("%Y-%m-%d").alias("b")