fix: (#930)

fix join when using string literals
narwhals-dev · Sep 9, 2024 · 767fbfb · 767fbfb
1 parent e7b3b83
commit 767fbfb
Show file tree

Hide file tree

Showing 2 changed files with 191 additions and 96 deletions.
diff --git a/narwhals/_pandas_like/dataframe.py b/narwhals/_pandas_like/dataframe.py
@@ -404,6 +404,10 @@ def join(
         left_on: str | list[str] | None,
         right_on: str | list[str] | None,
     ) -> Self:
+        if isinstance(left_on, str):
+            left_on = [left_on]
+        if isinstance(right_on, str):
+            right_on = [right_on]
         if how == "cross":
             if (
                 self._implementation is Implementation.MODIN