start adding tests

narwhals/pandas_like/dataframe.py

@@ -159,7 +159,7 @@ def to_pandas(self) -> Any:
     def to_dict(self, *, as_series: bool = True) -> dict[str, Any]:
         if as_series:
             return {col: self._dataframe[col] for col in self._dataframe.columns}
-        return self._dataframe.to_dict(orient="list")
+        return self._dataframe.to_dict(orient="list")  # type: ignore[no-any-return]
 
 
 class LazyFrame(LazyFrameProtocol):

narwhals/pandas_like/group_by.py

@@ -96,10 +96,10 @@ def agg(
                     out[result_keys.name].append(result_keys.item())
 
         results_keys = dataframe_from_dict(out, implementation=implementation)
-        results_keys = horizontal_concat(
+        results_df = horizontal_concat(
             [results_keys, *dfs], implementation=implementation
         ).loc[:, output_names]
-        return self._from_dataframe(results_keys)
+        return self._from_dataframe(results_df)
 
     def _from_dataframe(self, df: DataFrame) -> LazyFrame:
         from narwhals.pandas_like.dataframe import LazyFrame

tests/tpch_test.py

@@ -28,7 +28,7 @@ def compare_dicts(result: dict[str, Any], expected: dict[str, Any]) -> None:
 def test_q1(df_raw: Any) -> None:
     var_1 = datetime(1998, 9, 2)
     df, pl = to_polars_api(df_raw, version="0.20")
-    result = (
+    query_result = (
         df.filter(pl.col("l_shipdate") <= var_1)
         .group_by(["l_returnflag", "l_linestatus"])
         .agg(
@@ -53,7 +53,7 @@ def test_q1(df_raw: Any) -> None:
         )
         .sort(["l_returnflag", "l_linestatus"])
     )
-    result = result.collect().to_dict(as_series=False)
+    result = query_result.collect().to_dict(as_series=False)
     expected = {
         "l_returnflag": ["A", "N", "N", "R"],
         "l_linestatus": ["F", "F", "O", "F"],