forgot a file

narwhals-dev · Dec 27, 2024 · 5c565a4 · 5c565a4
1 parent 6ad961e
commit 5c565a4
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/narwhals/_pandas_like/expr.py b/narwhals/_pandas_like/expr.py
@@ -448,9 +448,12 @@ def func(df: PandasLikeDataFrame) -> list[PandasLikeSeries]:
                 if self._function_name == "col->shift":
                     kwargs = {"periods": self._kwargs.get("n", 1)}
                 elif self._function_name == "col->rank":
+                    _method = self._kwargs.get("method", "average")
                     kwargs = {
-                        "method": self._kwargs.get("method", "average"),
+                        "method": "first" if _method == "ordinal" else _method,
                         "ascending": not self._kwargs.get("descending", False),
+                        "na_option": "keep",
+                        "pct": False,
                     }
                 else:  # Cumulative operation
                     kwargs = {"skipna": True}