Skip to content

Commit

Permalink
Update narwhals/_pandas_like/expr.py
Browse files Browse the repository at this point in the history
Accept comment

Co-authored-by: Francesco Bruzzesi <[email protected]>
  • Loading branch information
ClaudioSalvatoreArcidiacono and FBruzzesi authored Dec 23, 2024
1 parent 86ad30f commit 1d9e746
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions narwhals/_pandas_like/expr.py
Original file line number Diff line number Diff line change
Expand Up @@ -445,9 +445,7 @@ def func(df: PandasLikeDataFrame) -> list[PandasLikeSeries]:
df = df.with_columns(~plx.col(*self._root_names).is_null())

if self._function_name == "col->shift":
kwargs = {
"periods": (self._kwargs.get("n", 1) if self._kwargs else 1)
}
kwargs = {"periods": self._kwargs.get("n", 1)}
else:
# Cumulative operation
kwargs = {"skipna": True}
Expand Down

0 comments on commit 1d9e746

Please sign in to comment.