Update ReactNativePaymentsModule.java #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new methods: setTheme(int Theme); setLightTheme(); setDarkTheme(); addAllowedCardNetwork();
naoufal
reviewed
Oct 31, 2017
| .build(); | ||
| break; | ||
| default: | ||
| // TODO warning |
There was a problem hiding this comment.
What do you have planned for a warning?
| @@ -54,6 +66,10 @@ | |||
|
|
|||
| public static final String REACT_CLASS = "ReactNativePayments"; | |||
|
|
|||
| private int theme = WalletConstants.THEME_LIGHT; | |||
There was a problem hiding this comment.
Can you confirm that this is the default theme?
|
|
||
| constants.put("PAYMENT_METHOD_TOKENIZATION_TYPE_PAYMENT_GATEWAY", PaymentMethodTokenizationType.PAYMENT_GATEWAY); // Adyen,Braintree,Stripe,Vantiv | ||
| constants.put("PAYMENT_METHOD_TOKENIZATION_TYPE_NETWORK_TOKEN", PaymentMethodTokenizationType.NETWORK_TOKEN); | ||
| // constants.put("PAYMENT_METHOD_TOKENIZATION_TYPE_DIRECT", WalletConstants.PAYMENT_METHOD_TOKENIZATION_TYPE_DIRECT); |
| this.theme = theme; | ||
| } | ||
| @ReactMethod | ||
| public void setLightTheme(int theme) { |
There was a problem hiding this comment.
Let's drop the theme parameter here since it isn't being used.
| // Public Methods | ||
| // --------------------------------------------------------------------------------------------- | ||
| @ReactMethod | ||
| public void setTheme(int theme) { |
There was a problem hiding this comment.
Developers shouldn't have to interactive with the native module to set the theme.
Instead, I'd expose this via the configuration data on paymentMethodData. That way users decide the theme prior to initializing the PaymentRequest.
| return parametersBuilder.build(); | ||
| String publicKey = ""; | ||
| switch( tokenizationParameters.getString("tokenizationType")) { | ||
| /*case WalletConstants.PAYMENT_METHOD_TOKENIZATION_TYPE_DIRECT: |
There was a problem hiding this comment.
I didn't realize there was a Direct Type.
Is it worth uncommenting and adding it to the PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new methods:
setTheme(ReactNativePayments.THEME_DARK);
setLightTheme();
setDarkTheme();
addAllowedCardNetwork(ReactNativePayments.CARD_NETWORK_AMEX);
new contants:
ReactNativePayments.CARD_NETWORK_*
ReactNativePayments.THEME_LIGHT
ReactNativePayments.THEME_DARK