-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting firstdata gateway #213
Open
giriprathap
wants to merge
67
commits into
addons-integration-next
Choose a base branch
from
master
base: addons-integration-next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also allow us to display PKPaymentAuthorizationViewController over modal!
Doing this, underlying button view sets its frame from parent's frame.
- view managers are singletons, view should not be cached. - this fix allows us to have multiple button views
For example, when running in a JavaScript test runner, the native addons do not exist, but a simple import of the module should not fail.
Fixed broken android-pay link.
Hey @giriprathap , thanks for your contribution. Could you please explain the changes you made? The rebase makes it hard to see. It looks like you added |
* Add cornerRadius prop * Add native support for cornerRadius * Update docs
* allow 0 as a total for payment * also allow 0 for things like tax/etc.
#133) * Add ios react native directory to header search paths (for pods) * Make the ios search path recursive * Bump to 0.7.2 * Update ReactNativePayments.m Add support for MADA payment Saudi Arabia Co-authored-by: rkaartikeyan <[email protected]>
* Add billingContact and shippingContact to paymentResponse on iOS Require billing address with additional option 'requireBilling' * Add name to billingContact and shippingContact Remove billingContact and shippingContact reference that is in the wrong place and is always undefined. It should only be in the details field.
Correctly pass on promise failure of NativePayments.show()
* Add ios react native directory to header search paths (for pods) * Make the ios search path recursive * Bump to 0.7.2 * Update ReactNativePayments.m Add support for MADA payment Saudi Arabia * sync from react-native-easy-payments * fixed this on the intents branch which isn’t quite ready yet, so I’ll commit here * bugfix - incompatible export of PKPaymentButton * update readme linking to iOS example project * update organization name format * delete old stripe project so people don't get confused * also delete braintree, the iOS example project explains clearly how to use it Co-authored-by: rkaartikeyan <[email protected]>
…tanding but it broke my tests (#255)
* Added paymentMethod field to applepay details * fix compilation error * Added static canMakePaymentsUsingNetworks method * Add billingContact and shippingContact to paymentResponse on iOS Require billing address with additional option 'requireBilling' * Add name to billingContact and shippingContact Remove billingContact and shippingContact reference that is in the wrong place and is always undefined. It should only be in the details field. * bump version to 0.7.2 * Add license * remove unnecessary json parsing; uniform method names; fix activation state * Revert "Add license" This reverts commit 1f1e6d8. * fix podspec * fix billing/shipping stuff * Zero Amount (#5) * validate ios version to authorize amount = 0 only for version greater or equal to 12.0 * bump version * Zero price payments (#6) * validate ios version to authorize amount = 0 only for version greater or equal to 12.0 * bump version * change name of the method to validate the support of zero amount and change if condition * bump version * support for androidx * remove packages folder * remove conflicts with xcode projects and tabs v whitespace * weird whitespace / tab conflicts * weird whitespace / tab conflicts * deleted package lock by mistake * adds Truphone to the list of organizations Co-authored-by: ACOSW <[email protected]> Co-authored-by: Mitch Martin <[email protected]> Co-authored-by: nricardo <[email protected]> Co-authored-by: ThasMe,Joana <[email protected]>
* Update broken links * Use relative links Co-authored-by: Rakesh Arunachalam <[email protected]>
…ly a ShippingOption change (#290) * Do not trigger a ShippingOption reset if the original event is actually a ShippingOption change * Add missing &&
* fix: make abort method on PaymentRequest actually return a Promise<void>, thereby properly cancelling event listeners * chore: use single quotes * chore: fix accidental removal of get shippingAddress getter
…ions have dropped Obj-C headers)
👍 Done, but it might be a while before this gets released in an official version. Feel free to install against the commit or master branch. (and check out the README on front page)
More information about the future of the repo and available alternatives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supportedGateways: IS_ANDROID
? ['stripe', 'braintree', 'firstdata'] // On Android, Payment Gateways are supported out of the gate.
: ReactNativePayments ? ReactNativePayments.supportedGateways : []