-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuzzing fixes #147
Fuzzing fixes #147
Conversation
Why not check the exact error? |
For what? Generally speaking, this is coming up next. I'm just trying to keep the PR sizes down, but the EdnError rework is pretty big EdnError won't be string based. It also won't be possible for user/test code to be able to create an arbitrary EdnError. Nor does it have added requirements like Eq or heap allocation. More testing can be added to the future After EdnError rework, I also had some WIP instrumentation coverage testing to get 100% coverage for messages, which is where these should be tested/specified |
122eeaf
to
4d2eabc
Compare
Rebased and just removed the commit dealing with tests, just to get things untangled. |
4d2eabc
to
b53691b
Compare
Cleaned up/rebased version of #125.
This PR is mostly for the tests and history, the actual parsing implementation (clone version) will be replaced in a future PR with the EdnError/parse rework as seen in Grinkers#6. I can squash it all, but I think this will make things easier to review.