edn-rs/edn-rs <- Grinkers/edn-rs
#140
Conversation
|
edn-rs now passes roundtrip with clojure (jvm)'s own edn fuzzer |
|
trait Serialize uses reference to self instead of move |
|
Edn::Rational from String to (i64, u64) |
|
EdnError rework with parse rewrite |
src/edn/mod.rs
Outdated
| @@ -780,15 +719,6 @@ mod test { | |||
| use alloc::vec; | |||
|
|
|||
| use super::*; | |||
| #[test] | |||
There was a problem hiding this comment.
do we have these tests covered elsewhere?
There was a problem hiding this comment.
I removed them because with (i64, u64) they're infallable
|
@naomijub Thanks for starting to look at this. Instead of dealing with this huge draft PR, with some details inside that we may not want to upstream without discussion, I'll start breaking them apart piece by piece and squashing as we go. I mostly put this here for me to track. We'll have to do it linearly though, I don't want to rebase/isolate 15 separate times; it's work built on top of other work. For example, Rational can be looked at in isolation, but after some other things. |
|
Thinking about it, I'll start rebasing against edn-rs/main and deleting comments as we go. Think of this as more of an automatic linear issue tracker. Will delete when there's nothing left! |
Grinkers
force-pushed
the
main
branch
3 times, most recently
from
162a65d to
71f7fc5
Compare
Grinkers
force-pushed
the
main
branch
6 times, most recently
from
ab7596a to
2c10a54
Compare
…ts on `take_while`s.
…ing, with well defined data.
…re for checking invalid EDN, not user messages.
Issue discussion:
#139