Skip to content

Commit

Permalink
adding default netmask in flags (#1145)
Browse files Browse the repository at this point in the history
Co-authored-by: ian eyberg <[email protected]>
  • Loading branch information
eyberg and ian eyberg authored Aug 6, 2021
1 parent 185bb0c commit 842992f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion cmd/flags_build_image.go
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ func PersistBuildImageCommandFlags(cmdFlags *pflag.FlagSet) {
cmdFlags.String("ip-address", "", "static ip address")
cmdFlags.String("ipv6-address", "", "static ipv6 address")
cmdFlags.String("gateway", "", "network gateway")
cmdFlags.String("netmask", "", "network mask")
cmdFlags.String("netmask", "255.255.255.0", "network mask")
}

func setNanosBaseImage(c *types.Config) {
Expand Down
1 change: 1 addition & 0 deletions cmd/flags_build_image_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ func TestBuildImageFlagsMergeToConfig(t *testing.T) {
},
RunConfig: types.RunConfig{
Imagename: imagesPath + "/test-image.img",
NetMask: "255.255.255.0",
},
Args: []string{"MyTestApp", "a b c d"},
Program: "MyTestApp",
Expand Down
4 changes: 2 additions & 2 deletions qemu/hv_support_darwin.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package qemu

// +build darwin

package qemu

import (
"bytes"
"fmt"
Expand Down

0 comments on commit 842992f

Please sign in to comment.