Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aio: task_abort was a mistake #1978

Merged
merged 1 commit into from
Dec 8, 2024
Merged

aio: task_abort was a mistake #1978

merged 1 commit into from
Dec 8, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 8, 2024

The use of task_abort to prematurely fail an aio at scheduling time was a mistake, because it could have led to duplicate calls to nng_aio_finish(). We do need to ensure that we leave an indicator so that nni_aio_schedule can return the abort status to caller, in the case that abort is called between the nni_aio_begin and nni_aio_schedule calls.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

The use of task_abort to prematurely fail an aio at scheduling
time was a mistake, because it could have led to duplicate calls
to nng_aio_finish().  We do need to ensure that we leave an indicator
so that nni_aio_schedule can return the abort status to caller,
in the case that abort is called between the nni_aio_begin and
nni_aio_schedule calls.
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.80%. Comparing base (8af6bef) to head (3ca7bcc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/aio.c 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1978      +/-   ##
==========================================
- Coverage   81.92%   81.80%   -0.12%     
==========================================
  Files          95       95              
  Lines       24071    24063       -8     
  Branches     3207     3207              
==========================================
- Hits        19719    19685      -34     
- Misses       4279     4306      +27     
+ Partials       73       72       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 3ca7bcc into main Dec 8, 2024
16 of 19 checks passed
@gdamore gdamore deleted the kill-task-abort branch December 8, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant