Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: fixes for socket holds and leaking aio data #1977

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 8, 2024

The aio structures need to be finalized, and the sockets should be held until the device is totally finalized to prevent any possible use after free.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

The aio structures need to be finalized, and the sockets should
be held until the device is totally finalized to prevent any
possible use after free.
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (45ad63d) to head (8af6bef).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1977      +/-   ##
==========================================
+ Coverage   81.83%   81.92%   +0.08%     
==========================================
  Files          95       95              
  Lines       24068    24071       +3     
  Branches     3206     3207       +1     
==========================================
+ Hits        19696    19719      +23     
+ Misses       4300     4279      -21     
- Partials       72       73       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 8af6bef into main Dec 8, 2024
17 of 19 checks passed
@gdamore gdamore deleted the device-sock-hold branch December 8, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant