Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sockfd: check the result of nni_aio_schedule #1957

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 4, 2024

This fixes a possible failure condition on teardown.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

This fixes a possible failure condition on teardown.
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.84%. Comparing base (d017a6a) to head (397b500).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/sockfd.c 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1957      +/-   ##
==========================================
+ Coverage   81.79%   81.84%   +0.05%     
==========================================
  Files          94       94              
  Lines       24006    24007       +1     
  Branches     3199     3200       +1     
==========================================
+ Hits        19635    19648      +13     
+ Misses       4299     4283      -16     
- Partials       72       76       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 397b500 into main Dec 4, 2024
15 of 19 checks passed
@gdamore gdamore deleted the sockfd-aio-schedule branch December 4, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant