Nuts tests #1952
Merged
Nuts tests #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds more tests for additional test cases (aio, and more validations of incompatible device configurations).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1952 +/- ##
==========================================
+ Coverage 81.59% 81.87% +0.27%
==========================================
Files 94 94
Lines 24010 24010
Branches 3199 3199
==========================================
+ Hits 19591 19658 +67
+ Misses 4347 4281 -66
+ Partials 72 71 -1 ☔ View full report in Codecov by Sentry. |
This actually represents a conversion of the transport tests implemented in Convey terms to NUTS. As part of this, have implemented a simple round trip performance test, using PAIR. The rest of the transport tests will shortly be converted to this as well.
TCPv6 not done yet since that needs special work to be conditionalized. Also tcpsupp remains to be converted.
While here we added a test for nng_cv_wake1 to demonstrate it does not fall afoul of the thundering herd.
Also renamed this to tcp_stream_test.
|
This only adds tests -- the bugs it is uncovering need to be fixed, so merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves a bunch of tests over to NUTS.