Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcp: remove the transport layer reference counting mechanism #1948

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Nov 25, 2024

The upper SP layer takes care not to destroy and endpoint while it has outstanding pipes.

It's possible that the dueling reference counts between the upper and lower layers have been responsible for some hangs on shutdown sometimes seen with other transports.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

The upper SP layer takes care not to destroy and endpoint
while it has outstanding pipes.

It's possible that the dueling reference counts between the upper
and lower layers have been responsible for some hangs on shutdown
sometimes seen with other transports.
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.29%. Comparing base (c3620e6) to head (f6ddada).

Files with missing lines Patch % Lines
src/sp/transport/tcp/tcp.c 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1948      +/-   ##
==========================================
- Coverage   81.59%   81.29%   -0.31%     
==========================================
  Files          94       94              
  Lines       24010    23988      -22     
  Branches     3199     3194       -5     
==========================================
- Hits        19591    19500      -91     
- Misses       4347     4416      +69     
  Partials       72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

We try to put the least likely stuff far from the hotter stuff in
the struct to get better cacheline efficiency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant