Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tls no extra resolver #1947

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Tls no extra resolver #1947

merged 2 commits into from
Nov 25, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Nov 25, 2024

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.59%. Comparing base (9c987eb) to head (c3620e6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/sp/transport/socket/sockfd.c 73.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1947      +/-   ##
==========================================
+ Coverage   80.23%   81.59%   +1.35%     
==========================================
  Files          92       94       +2     
  Lines       23446    24010     +564     
  Branches     3178     3199      +21     
==========================================
+ Hits        18813    19591     +778     
+ Misses       4633     4347     -286     
- Partials        0       72      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@gdamore gdamore merged commit c3620e6 into main Nov 25, 2024
18 of 19 checks passed
@gdamore gdamore deleted the tls-no-extra-resolver branch November 25, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant