Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all the get_ptr option accessors. #1946

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Remove all the get_ptr option accessors. #1946

merged 1 commit into from
Nov 25, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Nov 24, 2024

Temporarily we have removed access to the peer alt names, but that was never used and was not tested (it also didn't work with WolfSSL.)

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

Temporarily we have removed access to the peer alt names, but
that was never used and was not tested (it also didn't work with WolfSSL.)
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.40%. Comparing base (2afc725) to head (2df4d2e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1946      +/-   ##
==========================================
+ Coverage   81.11%   81.40%   +0.29%     
==========================================
  Files          94       94              
  Lines       24073    24037      -36     
  Branches     3208     3205       -3     
==========================================
+ Hits        19526    19568      +42     
+ Misses       4473     4396      -77     
+ Partials       74       73       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@gdamore gdamore merged commit 2df4d2e into main Nov 25, 2024
19 checks passed
@gdamore gdamore deleted the gdamore/no-get-ptr branch November 25, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant