Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websocket: Do not allow a listener or dialer to change TLS while running #1926

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Nov 10, 2024

This also covers a few test cases that we were missing.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.11%. Comparing base (0058b76) to head (cbe9a27).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1926      +/-   ##
==========================================
+ Coverage   81.00%   81.11%   +0.11%     
==========================================
  Files          94       94              
  Lines       24180    24194      +14     
  Branches     3240     3242       +2     
==========================================
+ Hits        19586    19624      +38     
+ Misses       4522     4497      -25     
- Partials       72       73       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This also covers a few test cases that we were missing.
@gdamore gdamore merged commit cbe9a27 into main Nov 10, 2024
18 of 19 checks passed
@gdamore gdamore deleted the better-ws-tests branch November 10, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant