Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS configuration changed to use discret _set_tls and _get_tls functi… #1925

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Nov 9, 2024

…ons.

This is simpler, and more reliable than using socket options.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

…ons.

This is simpler, and more reliable than using socket options.
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 84.57711% with 31 lines in your changes missing coverage. Please review.

Project coverage is 81.00%. Comparing base (150d80c) to head (0058b76).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/stream.c 71.42% 8 Missing ⚠️
src/sp/transport/ws/websocket.c 50.00% 6 Missing ⚠️
src/supplemental/websocket/websocket.c 81.81% 6 Missing ⚠️
src/nng.c 87.50% 4 Missing ⚠️
src/supplemental/http/http_server.c 85.71% 4 Missing ⚠️
src/core/dialer.c 90.00% 1 Missing ⚠️
src/core/listener.c 90.00% 1 Missing ⚠️
src/supplemental/http/http_client.c 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1925      +/-   ##
==========================================
+ Coverage   80.93%   81.00%   +0.06%     
==========================================
  Files          94       94              
  Lines       24089    24180      +91     
  Branches     3238     3240       +2     
==========================================
+ Hits        19497    19586      +89     
- Misses       4518     4522       +4     
+ Partials       74       72       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 0058b76 into main Nov 10, 2024
18 of 19 checks passed
@gdamore gdamore deleted the gdamore/set-tls branch November 10, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant