Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNG_OPT_RECVFD and NNG_OPT_SENDFD converted to functions. #1905

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Nov 2, 2024

These options are removed entirely, and their functionality is now available via special functions, nng_socket_get_send_poll_fd and nng_socket_get_recv_poll_fd, making these first class methods on the socket.

This eliminates a bit of wasteful code, and provides type safety for these methods.

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

These options are removed entirely, and their functionality is now
available via special functions, `nng_socket_get_send_poll_fd` and
`nng_socket_get_recv_poll_fd`, making these first class methods on
the socket.

This eliminates a bit of wasteful code, and provides type safety
for these methods.
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.07%. Comparing base (9b27984) to head (279180c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/nng.c 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1905      +/-   ##
==========================================
- Coverage   80.19%   80.07%   -0.12%     
==========================================
  Files          94       94              
  Lines       24260    24216      -44     
  Branches     3262     3246      -16     
==========================================
- Hits        19456    19392      -64     
- Misses       4731     4750      +19     
- Partials       73       74       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore gdamore merged commit 279180c into main Nov 3, 2024
16 of 17 checks passed
@gdamore gdamore deleted the gdamore/pollable-not-props branch November 3, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant