Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* FIX [core] fix a syntax error #1762

Closed
wants to merge 1 commit into from
Closed

Conversation

JaylinYu
Copy link
Contributor

@JaylinYu JaylinYu commented Jan 7, 2024

Don't know how it bypasses the CI, but clearly a wrong definition in the header file.

@gdamore gdamore self-requested a review January 7, 2024 15:14
Copy link
Contributor

@gdamore gdamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passes CI because its legal. It is valid to have both named and anonymous parameters.

Do you have an error message that this fixes?

@JaylinYu
Copy link
Contributor Author

JaylinYu commented Jan 8, 2024

This is reported by one of our customer.

nevermind, i believe the error is resulted from sth else.

@JaylinYu JaylinYu closed this Jan 8, 2024
@JaylinYu JaylinYu deleted the jaylin/nng branch January 8, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants