fixes #1572 nng creates too many threads #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdamore
force-pushed
the
gdamore/init-params
branch
from
e8ba739 to
e2ada26
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1755 +/- ##
==========================================
- Coverage 79.22% 79.21% -0.02%
==========================================
Files 94 94
Lines 21015 21074 +59
==========================================
+ Hits 16650 16693 +43
- Misses 4365 4381 +16 ☔ View full report in Codecov by Sentry. |
gdamore
force-pushed
the
gdamore/init-params
branch
2 times, most recently
from
24e3c7b to
db6f6af
Compare
This further limits some of the thread counts, but principally it offers a new runtime facility, nng_init_set_parameter(), which can be used to set certain runtime parameters on the number of threads, provided it is called before the rest of application start up. This facility is quite intentionally "undocumented", at least for now, as we want to limit our commitment to it. Still this should be helpful for applications that need to reduce the number of threads that are created.
gdamore
force-pushed
the
gdamore/init-params
branch
from
db6f6af to
4a45113
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This further limits some of the thread counts, but principally it offers a new runtime facility, nng_init_set_parameter(), which can be used to set certain runtime parameters on the number of threads, provided it is called before the rest of application start up.
This facility is quite intentionally "undocumented", at least for now, as we want to limit our commitment to it. Still this should be helpful for applications that need to reduce the number of threads that are created.