Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket:// transport (socketpair) #1742

Closed
wants to merge 1 commit into from
Closed

socket:// transport (socketpair) #1742

wants to merge 1 commit into from

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 26, 2023

Introduce socket:// transport.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 170 lines in your changes are missing coverage. Please review.

Comparison is base (9528f41) 79.42% compared to head (16d3140) 79.07%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/sp/transport/socket/sockfd.c 79.91% 94 Missing ⚠️
src/platform/posix/posix_sockfd.c 75.82% 51 Missing ⚠️
src/core/sockfd.c 77.55% 22 Missing ⚠️
src/platform/posix/posix_peerid.c 83.33% 2 Missing ⚠️
src/platform/posix/posix_socketpair.c 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1742      +/-   ##
==========================================
- Coverage   79.42%   79.07%   -0.36%     
==========================================
  Files          88       93       +5     
  Lines       20223    21024     +801     
==========================================
+ Hits        16062    16624     +562     
- Misses       4161     4400     +239     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…onnections

This transport only listens, and creates connections when
the application calls setopt on the lister with NNG_OPT_SOCKET_FD,
to pass a file descriptor.  The FD is turned into an nng_stream,
and utilized for SP.  The protocol over the descriptor is identical
to the TCP protocol (not the IPC protocol).

The options for peer information are borrowed from the IPC transport,
as they may be useful for these purposes.

This includes a test suite and full documentation.
@gdamore gdamore changed the title DRAFT: fdconn transport (socketpair) socket:// transport (socketpair) Dec 29, 2023
@gdamore
Copy link
Contributor Author

gdamore commented Dec 29, 2023

This was merged but github is confused. Closing.

@gdamore gdamore closed this Dec 29, 2023
@gdamore gdamore deleted the gdamore/fdconn branch December 29, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant