Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new nni_list_node named a_finish_node in struct nng_aio #1695

Closed
wants to merge 2 commits into from
Closed

Add a new nni_list_node named a_finish_node in struct nng_aio #1695

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a373f85
Unlocking of sub0_sock lock after aio is deleted from the finish list
willwu1217 Oct 24, 2023
436e217
Add finish nni_list in struct nng_aio
willwu1217 Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sp/protocol/pubsub0/sub.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,6 @@ sub0_recv_cb(void *arg)
nni_pollable_raise(&sock->readable);
}
}
nni_mtx_unlock(&sock->lk);

// NB: This is slightly less efficient in that we may have
// created an extra copy in the face of e.g. two subscriptions,
Expand All @@ -405,6 +404,7 @@ sub0_recv_cb(void *arg)
nni_list_remove(&finish, aio);
nni_aio_finish_sync(aio, 0, len);
}
nni_mtx_unlock(&sock->lk);

nni_pipe_recv(p->pipe, &p->aio_recv);
}
Expand Down