Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable debug logging for core tests #4807

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

gr0vity-dev
Copy link
Contributor

Failures on GitHub runners are sometimes hard to reproduce locally. Adding detailed logging helps analyze test failures directly from CI logs.

  • Enables NANO_LOG_STATS and debug level logging for core tests across all CI platforms
  • Helps diagnose intermittent test failures by providing more detailed execution traces

Enable NANO_LOG_STATS and debug level logging for core tests to help diagnose intermittent failures on CI runners
@gr0vity-dev-bot
Copy link

gr0vity-dev-bot commented Dec 7, 2024

Test Results for Commit 71ed4dd

Pull Request 4807: Results
Overall Status:

Test Case Results

  • 5n4pr_conf_10k_bintree: PASS (Duration: 110s)
  • 5n4pr_conf_10k_change: PASS (Duration: 182s)
  • 5n4pr_conf_change_dependant: PASS (Duration: 128s)
  • 5n4pr_conf_change_independant: PASS (Duration: 136s)
  • 5n4pr_conf_send_dependant: PASS (Duration: 124s)
  • 5n4pr_conf_send_independant: PASS (Duration: 131s)
  • 5n4pr_rocks_10k_bintree: PASS (Duration: 114s)
  • 5n4pr_rocks_10k_change: PASS (Duration: 175s)

Last updated: 2024-12-09 09:31:06 UTC

@pwojcikdev
Copy link
Contributor

I wouldn't enable this, the amount of logs generated is just enormous to the point where it's not possible to easily see which tests failed anymore because github truncates viewable log size. An approach similar to gtest-parallel might be better where only log output from failed tests is printed.

@gr0vity-dev
Copy link
Contributor Author

Oh right. when just running core_test without gtest-parallel, the output is always shown and will be huge. That's not what we want indeed!
Should we switch to gtest-parallel instead.
It will hide the output for all passing tests and just show failing tests.
We could set the --worker=1 so tests don't actually run in parallel

@pwojcikdev
Copy link
Contributor

Gtest-parallel was added as a submodule in submodules/gtest-parallel so perhaps the script can invoke it from there

@pwojcikdev
Copy link
Contributor

For some reason it no longer is able to show the sanitizer report https://github.com/nanocurrency/nano-node/actions/runs/12215820961/job/34078250929?pr=4807 It detects the problem, but the report is empty. Not sure what's going on here.

@gr0vity-dev gr0vity-dev force-pushed the prs/enable-debug-log-for-core-tests branch from c4feb1a to 948662a Compare December 9, 2024 07:26
@gr0vity-dev gr0vity-dev force-pushed the prs/enable-debug-log-for-core-tests branch from 948662a to 71ed4dd Compare December 9, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants