Fix ledger_priority.sequential_blocks testcase #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results for Commit 0e984b4Pull Request 4805: Results Test Case Results
Last updated: 2024-12-07 09:59:13 UTC |
pwojcikdev
reviewed
Dec 6, 2024
|
Good fix. I added this test recently, it was generated by Claude. I didn't notice it was comparing timestamps in this way. |
Different account chains are ot guaranteed to have the same priority timestamp. Openening could happen much later, independant of the sending. It can be euqal or greater
gr0vity-dev
force-pushed
the
prs/fix-ledger_priority-sequential_blocks
branch
from
ce5250d to
0e984b4
Compare
pwojcikdev
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw this testcase failing on the windows github runner.
Different account chains are not guaranteed to have the same priority timestamp.
The opening could happen much later than the sending.
If we add a 1 second delay between processing
send1andopen1, the testcase previously always failed.The opening timestamp of "key1 account" can be equal or greater than the matching send timestamp of "genesis account".