Fix flaky inactive_votes_cache.election_start test #4803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results for Commit c1c60f0Pull Request 4803: Results Test Case Results
Last updated: 2024-12-05 17:29:00 UTC |
pwojcikdev
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This testcase fails sometimes on the github runners. And in ~1/1000 cases on my machine.
nano::test::confirmed ()checks for confirmation being written to disk while node.ledger.cemented_count () uses cached cemented_count.Use ASSERT_TIMELY to give some time for disk I/O completion.