Use spaceship comparisons

[pwojcikdev]

The reason for starting this work was that nano::account didn't provide an ordering operators, but this reworks several aspects of other nano primitive types like nano::block_hash, nano::hash_or_account etc:

• Implements strong ordering of values for all types with the use of C++ <=> spaceship operator. Previously some types could not be ordered, like the mentioned nano::account
• Remove the use of reinterpret_cast 😬
• Keep definitions of commonly used functions inline in the header to hopefully enable more aggressive compiler optimizations
• Ensure that all types provide hashing adapters, for both std::hash and boost::hash

[clemahieu]

Very good cleanup.

[gr0vity-dev-bot]

Test Results for Commit 5d341f4

Pull Request 4767: Results
Overall Status: ✅

Test Case Results

• ✅ 5n4pr_conf_10k_bintree: PASS (Duration: 114s)
• ✅ 5n4pr_conf_10k_change: PASS (Duration: 208s)
• ✅ 5n4pr_conf_change_dependant: PASS (Duration: 153s)
• ✅ 5n4pr_conf_change_independant: PASS (Duration: 148s)
• ✅ 5n4pr_conf_send_dependant: PASS (Duration: 135s)
• ✅ 5n4pr_conf_send_independant: PASS (Duration: 137s)
• ✅ 5n4pr_rocks_10k_bintree: PASS (Duration: 115s)
• ✅ 5n4pr_rocks_10k_change: PASS (Duration: 226s)

Last updated: 2024-10-25 19:21:07 UTC