Remove node::process_confirmed (...)
#4758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results for Commit 8221c05Pull Request 4758: Results Test Case Results
Last updated: 2024-11-23 17:49:38 UTC |
pwojcikdev
force-pushed
the
remove-process-confirmed
branch
3 times, most recently
from
a2368a6 to
cd1519a
Compare
pwojcikdev
force-pushed
the
remove-process-confirmed
branch
from
cd1519a to
58f7169
Compare
# Conflicts: # nano/node/blockprocessor.cpp # nano/node/blockprocessor.hpp # nano/node/confirming_set.cpp # nano/node/election.cpp # nano/node/node.cpp
# Conflicts: # nano/lib/stats_enums.hpp # nano/node/node.hpp
Merged
…rmed # Conflicts: # nano/lib/stats_enums.hpp
clemahieu
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
node::process_confirmed (...)function. Blocks queued there could briefly find themselves in a limbo state, neither part of an active election or cementing set, which was racy.