Fix mismatched channel owners #4750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
changed the title
clemahieu
reviewed
Oct 15, 2024
| @@ -520,6 +520,8 @@ void nano::node::keepalive (std::string const & address_a, uint16_t port_a) | |||
|
|
|||
| void nano::node::inbound (const nano::message & message, const std::shared_ptr<nano::transport::channel> & channel) | |||
| { | |||
| debug_assert (channel->owner () == shared_from_this ()); // This node should be the channel owner | |||
There was a problem hiding this comment.
We could have owner return a naked pointer and compare against 'this' since we're not intending to manage lifetime. I'm fine with keeping this though since it's just test code.
There was a problem hiding this comment.
Yeah, if it was compiled in release then this should be done, but I try to avoid naked pointers unless absolutely necessary to avoid shooting myself in the foot accidentally.
clemahieu
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few testcases where messages were passed with channels belonging to other nodes, which was causing strange lifetime issues. This adds asserts to ensure this won't happen.