Simplify vote generator

[RickiNano]

This PR removes the vote_generator_threshold that generates an additional wait to bundle more votes into each message. That wait period adds voting latency.
The logic that handles processing of requests and candidates have also been simplified. There was also a bug that request would only process when candidates were empty.
Bob has performance tested this branch and found no performance improvement nor degredatation

An interesting side effect is that the amount of active election timeouts dropped with this branch

Here is some testing on the NanoTicker node on live network. The screenshots are taken right after the daily saturation test.

[gr0vity-dev-bot]

Test Results for Commit dd08220

Pull Request 4748: Results
Overall Status: ✅

Test Case Results

• ✅ 5n4pr_conf_10k_bintree: PASS (Duration: 109s)
• ✅ 5n4pr_conf_10k_change: PASS (Duration: 212s)
• ✅ 5n4pr_conf_change_dependant: PASS (Duration: 156s)
• ✅ 5n4pr_conf_change_independant: PASS (Duration: 156s)
• ✅ 5n4pr_conf_send_dependant: PASS (Duration: 157s)
• ✅ 5n4pr_conf_send_independant: PASS (Duration: 138s)
• ✅ 5n4pr_rocks_10k_bintree: PASS (Duration: 106s)
• ✅ 5n4pr_rocks_10k_change: PASS (Duration: 216s)

Last updated: 2024-10-21 15:34:18 UTC