Network filter for votes #4735
Merged
Network filter for votes #4735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
force-pushed
the
vote-duplicate-filter
branch
from
1d07e46 to
c9ee536
Compare
clemahieu
approved these changes
Sep 25, 2024
RickiNano
pushed a commit
to RickiNano/nano-node
that referenced
this pull request
Oct 2, 2024
…ilter Network filter for votes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This filters out vote duplicates early on during packet processing. This showed significant reduction in number of processed votes for synthetic network simulations and when running on a live network representative.
The network filter now implements an age cutoff for its entries, so rebroadcasts are allowed after 60 seconds by default. This should remove the need for explicit clearing in case entries are dropped further in the pipeline.
Test results from @gr0vity-dev, his help was invaluable in detecting and fixing this inefficiency: