Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace legacy XRB ratios #4733

Merged
merged 12 commits into from
Sep 28, 2024
Merged

Conversation

RickiNano
Copy link
Contributor

This PR cleans up the old xrb ratios and replaces them with nano_ratio.

Existing name ratio Value New name
Gxrb_ratio 10^33 1000 nano Knano_ratio
Mxrb_ratio 10^30 1 nano nano_ratio
kxrb_ratio 10^27 0.001 nano removed
xrb_ratio 10^24 0.000001 removed

Ideally we would want to have only Nano and Raw ratios, but Gxrb_ratio (1000 nano) was referenced so many places in code that I kept it but renamed it to Knano_ratio.

The following deprecated RPC endpoints for conversion has been removed:

  • krai_from_raw
  • krai_to_raw
  • mrai_from_raw
  • mrai_to_raw
  • rai_from_raw
  • rai_to_raw

@clemahieu clemahieu merged commit 084e509 into nanocurrency:develop Sep 28, 2024
27 of 28 checks passed
@qwahzi qwahzi added this to the V28 milestone Oct 22, 2024
@qwahzi qwahzi added documentation This item indicates the need for or supplies updated or expanded documentation rpc Changes related to Remote Procedure Calls labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This item indicates the need for or supplies updated or expanded documentation rpc Changes related to Remote Procedure Calls
Projects
Status: Merged / V28.0
Development

Successfully merging this pull request may close these issues.

3 participants