Overhaul of online_reps class
#4656
Open
+393
−192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
force-pushed
the
online-reps-overhaul
branch
from
81d6990 to
20a6241
Compare
gr0vity-dev
pushed a commit
to gr0vity-dev/nano-node
that referenced
this pull request
Jun 26, 2024
gr0vity-dev
pushed a commit
to gr0vity-dev/nano-node
that referenced
this pull request
Jun 26, 2024
gr0vity-dev
pushed a commit
to gr0vity-dev/nano-node
that referenced
this pull request
Jun 26, 2024
gr0vity-dev
pushed a commit
to gr0vity-dev/nano-node
that referenced
this pull request
Jul 7, 2024
clemahieu
previously approved these changes
Jul 15, 2024
# Conflicts: # nano/core_test/node.cpp # nano/lib/logging_enums.hpp # nano/lib/stats_enums.hpp # nano/lib/thread_roles.cpp # nano/lib/thread_roles.hpp # nano/node/node.cpp # nano/node/node.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an overhaul of
online_repsclass:store.online_weight.count ()and erasing entries based on their timestamps instead (2 weeks for live, 1 day for beta).nano::online_reps::trended ()can never return value lower than the limit configured viaonline_weight_minimum.