-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate_database_lmdb_to_rocksdb improvements #4647
Conversation
This should be using node logger not cout, otherwise logs aren't saved to disk. There are some places in the existing code that are using cout too, but those are leftovers. Also, printing progress every x converted entries would be nice. |
And that's exactly the reason why it should be logged well, in line with production ready code. In case something goes wrong there should be a persistent record. |
ce5a2f3
to
48d4e6f
Compare
@pwojcikdev |
cdfaa6a
to
e8ba8ba
Compare
6a2923b
to
fa9180f
Compare
3ebe2fb
to
8191ce7
Compare
14c0217
to
59e874b
Compare
175d9d7
to
317f185
Compare
The
migrate_database_lmdb_to_rocksdb
option is running for a very long time with the current ledger size (almost 200 million blocks). On my local machine it took 65 minutes to complete. Nothing is written on screen during this process and users may think the process has stalled.This PR adds some progress feedback. One update for each of the 7 tables that are migrated.
It also adds a simple disk space check to warn users if they might not have enough space to complete the migration.
The current converted RocksDb database is 73 GB, and the warning is given if the system has less than 75GB available.The warning is given based on the size of the LMDB database that is being migrated. The final RocksDb size is approximately 65% of the LMDB space.