Optimize cemented callbacks #4642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
force-pushed
the
cemented-observers-optimize
branch
from
1caf7fa to
b5f58df
Compare
pwojcikdev
force-pushed
the
cemented-observers-optimize
branch
2 times, most recently
from
dcbb985 to
48f4b0c
Compare
pwojcikdev
force-pushed
the
cemented-observers-optimize
branch
2 times, most recently
from
9f19e65 to
4204f98
Compare
clemahieu
approved these changes
Jun 18, 2024
|
This usage of asio thread pool isn't really correct. Thread pool is designed to process many short lived tasks, and if they're doing io they should be non-blocking (using async io). This is not the case with our current database operations. Because of that, a single task can block others for a potentially long amount of time. To workaround this, each thread pool should process homogenous workload. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to optimize the election cementing callbacks. It often takes as long or even longer to cement a confirmed election as it takes to get it confirmed in the first place. This is not a complete solution, there is still a delay, but I hope it's a step in the right direction.
We're debugging this together with @gr0vity-dev who really is doing incredible work to dig deep into this issue.