Add per-bucket election limiter #4623
Open
+209
−403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
commented
May 14, 2024
clemahieu
force-pushed
the
merge_buckets_priority
branch
2 times, most recently
from
312be5a to
0e83188
Compare
clemahieu
force-pushed
the
merge_buckets_priority
branch
from
0e83188 to
46f9ad5
Compare
clemahieu
force-pushed
the
merge_buckets_priority
branch
2 times, most recently
from
9b4b604 to
408a4cf
Compare
…cket maximum. The number of elections started for a particular bucket is now limited on a per-bucket basis rather than globally across all buckets.
clemahieu
force-pushed
the
merge_buckets_priority
branch
from
408a4cf to
9c7d417
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a simpler version of the priority scheduler per-bucket limiter that tracks the number of elections it's started while retaining the ability to queue blocks for activation once elections already started for the bucket complete.
This removes the priority scheduler thread. Elections are activated at time of call to ::activate or when a different election is being cleaned up.