Blockprocessor context #4424
Merged
Blockprocessor context #4424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
force-pushed
the
blockprocessor-context
branch
from
0c24485 to
124421b
Compare
pwojcikdev
force-pushed
the
blockprocessor-context
branch
from
8a968e9 to
e5d0428
Compare
dsiganos
reviewed
Feb 9, 2024
pwojcikdev
force-pushed
the
blockprocessor-context
branch
from
e5d0428 to
9a80f29
Compare
dsiganos
previously approved these changes
Feb 9, 2024
pwojcikdev
force-pushed
the
blockprocessor-context
branch
from
a53a45d to
f6a32c9
Compare
pwojcikdev
force-pushed
the
blockprocessor-context
branch
from
af68559 to
5927a95
Compare
clemahieu
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
contextto every blockprocessor entry. This simplifies quite a bit of code and removes the need for auxiliary classes, which historically were prone to subtle bugs (#4240).