Remove block_processor::flush function #4404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsiganos
reviewed
Jan 28, 2024
clemahieu
force-pushed
the
block_processor_flush_remove
branch
4 times, most recently
from
f040f7c to
8ae15f3
Compare
…T_TIMELY for the expected behaviour for the test.
…moving bootstrap_processor::flush.
clemahieu
force-pushed
the
block_processor_flush_remove
branch
from
8ae15f3 to
0ce4ed4
Compare
dsiganos
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ::flush style functions have been disfavored as they're error and deadlock-prone. Depending on them in unit tests is problematic as their effect can change over time as components are added or removed from the node.
Removing the block_processor::flush function is done in 5 commits with increasing complexity and finally removing it from the legacy bootstrap processor as well its implementation in the final commit.