Simplify system::get_available_port() #4388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsiganos
added
non-functional change
exclude from changelog
dsiganos
force-pushed
the
simplify_get_available_port
branch
from
0b2fc82 to
eaf5c3c
Compare
clemahieu
previously approved these changes
Jan 23, 2024
The function get_available_port is too confusing. To simplify it, I am refactoring one test job it has into a separate test function. The test function speculatively chooses a free tcp binding port, for one unit test case, to check that the node can be configured with a manual port.
dsiganos
force-pushed
the
simplify_get_available_port
branch
from
eaf5c3c to
1f11700
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function get_available_port is too confusing. To simplify it, I am refactoring one test job it has into a separate test function.
The test function speculatively chooses a free tcp binding port, for one unit test case, to check that the node can be configured with a manual port.