Remove cleanup functions related to unchecked blocks. #4384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We do not need a periodic cleanup as long as new entries replace old ones. |
dsiganos
previously approved these changes
Jan 22, 2024
pwojcikdev
previously approved these changes
Jan 22, 2024
These functions are no longer relevant since the blocks are now stored in memory and are bounded.
clemahieu
force-pushed
the
remove_unchecked_clear_startup
branch
from
f4ce5b9 to
f9c9915
Compare
dsiganos
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the addition of the ascending bootstrapped, all unchecked blocks are held in memory and there is already a size limit on how many are kept in the container. Previously these blocks were stored on disk and the number of items was unbounded which necessitated periodic cleanup.
Cleaning the unchecked blocks could actually negatively affect the ascending bootstrapper and clobber critical blocks it needs causing the need to download them again.