Hinted scheduler improvements #4312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This degrades performance, should be solved without additional coupling between election and conf height processor
This is bad
pwojcikdev
force-pushed
the
hinted-fixing-2-develop
branch
from
d751b38 to
91ffaf2
Compare
clemahieu
approved these changes
Oct 16, 2023
| { | ||
| // Check if there is space inside AEC for a new hinted election | ||
| if (active.vacancy (nano::election_behavior::hinted) > 0) | ||
| { | ||
| // Check if there is any vote cache entry surpassing our minimum vote tally threshold |
There was a problem hiding this comment.
Agree this should be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for an improved election hinting mechanism. The difference it brings seems to be quite significant, especially under heavily desynchronised network conditions, where timestamps discrepancies between nodes make it impossible to rely on the normal election scheduling system.
The current problem for the network is that under high load, elections sooner or later degrade to the point when part of the network has block dependencies confirmed, while the rest does not. I guess it's because some votes get dropped, but it's a separate problem and debugging is still ongoing. To workaround this issue, a new hinted scheduler design tries to 'detect' cases where our node falls back behind the network and activate elections for blocks that were missed.
When working on this solution, I received incredible help from @gr0vity-dev which brought my prototype from good enough to something that should be really robust and efficient. Thanks!